Fix Cypher when filtering by aggregations over different relationship properties types

[darrellwarde]

Description

Fix Cypher when filtering by aggregations over different relationship properites types. Previously this would error during translation.

Complexity

Complexity: Low

[changeset-bot]

🦋 Changeset detected

Latest commit: 66d46ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@neo4j/graphql	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[neo4j-team-graphql]

Performance Report

No Performance Changes

Show Full Table

name	dbHits	old dbHits	time (ms)	old time (ms)	maxRows
aggregations.TopLevelAggregate	3404	3404	37	49	1134
aggregations.TopLevelAggregateWithMultipleFields	6802	6802	46	55	1134
aggregations.NestedAggregation	15407	15407	63	98	2174
aggregations.AggregationWithWhere	10833	10833	43	70	2174
aggregations.AggregationWhereWithinNestedRelationships	20097917	20097917	2078	2167	2008534
aggregations.AggregationWhereWithinNestedConnections	20097917	20097917	2076	2105	2008534
aggregations.NestedCountFromMovieToActors	8603	8603	33	45	2174
aggregations.NestedCountFromActorsToMovie	8791	8791	36	54	2174
aggregations.DeeplyNestedCount	10052335	10052335	2518	2712	2008534
aggregations.InterfacesAggregations	6242	6242	48	58	2080
aggregations.InterfacesAggregationsWithTwoFields	11444	11444	79	93	2080
batch-create.BatchCreate	4200	4200	137	163	600
batch-create.BatchCreateSmall	77	77	52	72	11
connect.createAndConnect	6433	6433	132	188	3003
connections.Connection	12951	12951	57	73	2174
connections.NestedConnection	37705	37705	120	142	4516
create.SimpleMutation	7	7	53	70	1
cypher-directive.TopLevelMutationDirective	1135	1135	24	32	1134
delete.SimpleDelete	19401	19401	675	664	1040
2925.SingleRelationshipFilter	5245	5245	40	55	1040
2925.SingleRelationshipRequiredFilter	5201	5201	48	45	1040
query.SimpleQuery	3121	3121	25	27	1040
query.SimpleQueryWithRelationship	15031	15031	37	46	2174
query.SimpleQueryWithNestedWhere	8713	8713	51	58	2154
query.Nested	10084891	10084891	6504	6543	2008534
query.NestedWithFilter	10064992	10064992	6193	6261	2004000
query.OrFilterOnRelationships	36946	36724	150	214	2027
query.QueryWithNestedIn	14468	14480	54	67	1956
query.NestedConnectionWhere	8703	8703	52	99	2174
query.DeeplyNestedConnectionWhere	8702	8702	72	102	2174
query.DeeplyNestedWithRelationshipFilters	17357	17357	127	179	1552
query.NestedWithRelationshipSingleFilters	3808	3808	156	228	1134
query.Fulltext	64	64	31	44	16
query.FulltextWithNestedQuery	516	516	42	47	84
sorting-and-cypher.TopLevelSortWithCypher	12961	12961	41	51	2174
sorting-and-cypher.TopLevelConnectionSortWithCypher	12961	12961	63	68	2174
sorting-and-cypher.TopLevelSortWithCypherWithNested	13096	13096	74	66	2174
sorting-and-cypher.TopLevelConnectionSortWithCypherWithNested	13096	13096	102	111	2174
sorting-and-cypher.TopLevelSortWithExpensiveCypher	13720	13725	101	125	2174
sorting-and-cypher.TopLevelConnectionSortWithExpensiveCypher	13266	13266	107	108	2174
sorting.SortMultipleTypes	3436	3436	95	97	1040
sorting.SortMultipleTypesWithCypherWithCypher	13321	13321	109	120	2174
sorting.SortOnNestedFields	12951	12951	42	60	2174
sorting.SortDeeplyNestedFields	39785	39785	74	126	4516
sorting.ConnectionWithSort	3271	3271	74	111	1040
unions.SimpleUnionQuery	321	321	65	62	35
unions.SimpleUnionQueryWithMissingFields	293	293	54	71	35
unions.NestedUnion	309975	309975	339	273	33033
unions.NestedUnionWithMissingFields	283949	283949	259	270	33033
update.NestedUpdate	14137	14137	98	100	2002

Old Schema Generation: 26.697s
Schema Generation: 28.324s
Old Subgraph Schema Generation: 27.933s
Subgraph Schema Generation: 28.151s

[MacondoExpress]

Left a comment but apart that it looks good!

[MacondoExpress]

LGTM!