Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom resolved fields out of EventPayload type #4979

Merged
merged 7 commits into from
Apr 11, 2024
Merged

Conversation

a-alle
Copy link
Contributor

@a-alle a-alle commented Apr 4, 2024

Description

This PR eliminated fields annotated with @customResolver from the generated EventPayload type. In the case of interfaces, if any of its implementations has the field annotated, the field will not be part of the interface EventPayload type.

Complexity

Complexity: Low

Issue

Note

Please link to the GitHub issue(s) in which the proposal for this work was discussed

To link to multiple issues, use full syntax for each, for example Closes #1, closes #2, closes #3

Closes

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • TCK tests have been updated
  • Integration tests have been updated
  • Example applications have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed

Copy link

changeset-bot bot commented Apr 4, 2024

🦋 Changeset detected

Latest commit: e978804

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@neo4j/graphql Patch
@neo4j/graphql-ogm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

angrykoala
angrykoala previously approved these changes Apr 9, 2024
@angrykoala
Copy link
Member

Do we need a changeset for this PR?

angrykoala
angrykoala previously approved these changes Apr 11, 2024
@a-alle a-alle merged commit b730146 into neo4j:dev Apr 11, 2024
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Pull requests
Development

Successfully merging this pull request may close these issues.

3 participants