Add ability to test different cypher versions globally #725
Conversation
gem-neo4j
force-pushed
the
dev_test_cypher_versions
branch
from
9a31599 to
188ff80
Compare
gem-neo4j
force-pushed
the
dev_test_cypher_versions
branch
4 times, most recently
from
7c939a9 to
44f67bf
Compare
gem-neo4j
force-pushed
the
dev_test_cypher_versions
branch
from
44f67bf to
55d4729
Compare
| // A test may set this for the entire file itself, so we shouldn't override that | ||
| if (!globalConfig.containsKey(GraphDatabaseInternalSettings.default_cypher_version)) { | ||
| String cypherVersionEnv = System.getenv() | ||
| .getOrDefault("CYPHER_VERSION", GraphDatabaseInternalSettings.CypherVersion.Cypher25.name()); |
There was a problem hiding this comment.
Should we leave this as 25 going forward?
The plan is to ask for the TC builds to use the env to test both Cypher 5 and 25 in PR builds :)
There was a problem hiding this comment.
I vote for using 5 as default for now and setting it to 25 when mono repo has flipped.
| public static List<String> getCypherVersions() { | ||
| assert QueryLanguage.ALL.size() == 2; | ||
| return List.of("5", "25"); | ||
| } |
There was a problem hiding this comment.
Could also be a compilation failure:
| public static List<String> getCypherVersions() { | |
| assert QueryLanguage.ALL.size() == 2; | |
| return List.of("5", "25"); | |
| } | |
| public static List<String> getCypherVersions() { | |
| return QueryLanguage.ALL.stream() | |
| .map(l -> switch(l) { | |
| case Cypher5 -> "5"; | |
| case Cypher25 -> "25"; | |
| }) | |
| .toList(); | |
| } |
| assertResultAsJsonEquals( | ||
| CypherVersion.Default, | ||
| showFunctions(null), | ||
| showFunctions(CypherVersion.Default), |
There was a problem hiding this comment.
CypherVersion.Default is being removed. If you really need a default one you can use:
switch (GraphDatabaseSettings.default_langage.default()) {
case Cypher5 => CypherVerision.Cypher5;
case Cypher25 => CypherVerision.Cypher25;
}| assertResultAsJsonEquals( | ||
| CypherVersion.Default, | ||
| showProcedures(null), | ||
| showProcedures(CypherVersion.Default), |
| directory.toPath().toAbsolutePath()); | ||
| directory.toPath().toAbsolutePath()) | ||
| .withSetting( | ||
| GraphDatabaseInternalSettings.default_cypher_version, |
There was a problem hiding this comment.
This setting is being replaced by GraphDatabaseSettings.default_language. Unfortunately that is not hooked up yet (PR), so go ahead and merge this and I sort it out later.
| // A test may set this for the entire file itself, so we shouldn't override that | ||
| if (!globalConfig.containsKey(GraphDatabaseInternalSettings.default_cypher_version)) { | ||
| String cypherVersionEnv = System.getenv() | ||
| .getOrDefault("CYPHER_VERSION", GraphDatabaseInternalSettings.CypherVersion.Cypher25.name()); |
There was a problem hiding this comment.
I vote for using 5 as default for now and setting it to 25 when mono repo has flipped.
Add config and env variable to be able to test Cypher Versions - ready to fix all Cypher 25 test failures