[wvzcpHQH] Add SSFR check for apoc.spatial procedures #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AzuObs
suggested changes
Jan 26, 2023
vga91
force-pushed
the
blocklist_geocode
branch
from
9097787 to
7e162e7
Compare
|
@AzuObs ok, now it seems to work in the CI as well |
AzuObs
reviewed
Jan 31, 2023
AzuObs
reviewed
Jan 31, 2023
AzuObs
reviewed
Jan 31, 2023
AzuObs
suggested changes
Jan 31, 2023
There was a problem hiding this comment.
Thank you very much for fixing the tests. It's very pleasing to see that these tests clearly demonstrate that these procedures were already protected 🎉
I left a couple of nitpicks regarding the time these tests take to run, and also regarding whether these tests could be more readable.
vga91
force-pushed
the
blocklist_geocode
branch
from
76875cb to
0202999
Compare
vga91
force-pushed
the
blocklist_geocode
branch
from
0202999 to
9728eae
Compare
AzuObs
approved these changes
Feb 15, 2023
vga91
added a commit
to neo4j-contrib/neo4j-apoc-procedures
that referenced
this pull request
Feb 15, 2023
* [wvzcpHQH] Add SSFR check for apoc.spatial procedures * [wvzcpHQH] Fix test in the CI * [wvzcpHQH] added descriptive method and speed up tests
vga91
added a commit
to neo4j-contrib/neo4j-apoc-procedures
that referenced
this pull request
Feb 21, 2023
#3451) * [wvzcpHQH] Add SSFR check for apoc.spatial procedures (neo4j/apoc#305) * [wvzcpHQH] Add SSFR check for apoc.spatial procedures * [wvzcpHQH] Fix test in the CI * [wvzcpHQH] added descriptive method and speed up tests * [wvzcpHQH] changed err. message in 4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not necessary to change the implementation,
as both
apoc.spatial.geocodeandapoc.spatial.reverseGeocodecallJsonUtil.loadJson(...)which ends up on the work done in this pr.