Feat/forms button improvements #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #822 +/- ##
===========================================
- Coverage 39.55% 39.49% -0.07%
===========================================
Files 216 217 +1
Lines 9205 9225 +20
Branches 2732 2738 +6
===========================================
+ Hits 3641 3643 +2
- Misses 5503 5521 +18
Partials 61 61 ☔ View full report in Codecov by Sentry. |
|
Can you please check the code duplication and if you can add testing for this new behaviour in Cypress? Thank you so much for contributing to the project! |
|
alfredorubin96
approved these changes
Nov 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable forms button until all the necessary parameters are provided.
Description
This pull request introduces a modification to the forms functionality, specifically targeting the submit button. The primary change ensures that the submit button remains disabled until all the necessary parameters are provided by the user. This enhancement is essential for improving the user experience and preventing incomplete form submissions.
Changes Made
Screenshots
Actual Behaviour:
New Behaviour:
NOTICE
The program was tested solely for our own use cases, which might differ from yours.
Author Info: Monish monish.nandakumaran@mercedes-benz.com on behalf of Mercedes-Benz Research and Development India
https://github.com/mercedes-benz/mercedes-benz-foss/blob/master/PROVIDER_INFORMATION.md
Sample JSON:
movieDisableFormButton.json
Signed off: Monish monish.nandakumaran@mercedes-benz.com