Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RBAC extensions and dashboard access management #793

Merged
merged 42 commits into from
Feb 28, 2024

Conversation

nielsdejong
Copy link
Collaborator

No description provided.

AleSim94 and others added 28 commits January 8, 2024 16:48
…n a specific dashboard Node and remove them, still small thing left to fix
…put & creating a new label with same capital letter as existing labels. Also, added doc
…neo4j-labs/neodash into feature/customer_N_dashboard_RBAC_label
…neo4j-labs/neodash into feature/customer_N_dashboard_RBAC_label
@adriens
Copy link

adriens commented Feb 26, 2024

WOW, amazing feature 🤩

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 14.89362% with 200 lines in your changes are missing coverage. Please review.

Project coverage is 37.60%. Comparing base (20e4e0a) to head (7bd6f7a).
Report is 99 commits behind head on develop.

❗ Current head 7bd6f7a differs from pull request most recent head 751120d. Consider uploading reports for the commit 751120d to get more accurate results

Files Patch % Lines
src/extensions/rbac/RBACUtils.ts 6.55% 57 Missing ⚠️
src/extensions/rbac/RBACManagementModal.tsx 1.92% 51 Missing ⚠️
...oard/sidebar/modal/DashboardSidebarAccessModal.tsx 34.72% 47 Missing ⚠️
src/extensions/rbac/RBACManagementMenu.tsx 3.84% 25 Missing ⚠️
src/extensions/rbac/RBACManagementLabelButton.tsx 21.42% 11 Missing ⚠️
src/dashboard/sidebar/DashboardSidebar.tsx 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #793      +/-   ##
===========================================
- Coverage    39.07%   37.60%   -1.47%     
===========================================
  Files          208      216       +8     
  Lines         8721     9112     +391     
  Branches      2598     2685      +87     
===========================================
+ Hits          3408     3427      +19     
- Misses        5252     5628     +376     
+ Partials        61       57       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
15 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nielsdejong nielsdejong merged commit 8772663 into develop Feb 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants