Adjusting to default

Pie Margins default #486
neo4j-labs · Aug 22, 2023 · de3125a · de3125a
1 parent 6f17ce7
commit de3125a
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 15 deletions.
diff --git a/docs/modules/ROOT/pages/user-guide/reports/pie-chart.adoc b/docs/modules/ROOT/pages/user-guide/reports/pie-chart.adoc
@@ -73,13 +73,13 @@ slice.
 |Margin Left (px) |number |50 |The margin in pixels on the left side of
 the visualization.
 
-|Margin Right (px) |number |24 |The margin in pixels on the right side
+|Margin Right (px) |number |50 |The margin in pixels on the right side
 of the visualization.
 
-|Margin Top (px) |number |24 |The margin in pixels on the top side of
+|Margin Top (px) |number |50 |The margin in pixels on the top side of
 the visualization.
 
-|Margin Bottom (px) |number |40 |The margin in pixels on the bottom side
+|Margin Bottom (px) |number |50 |The margin in pixels on the bottom side
 of the visualization.
 
 |Hide Selections |on/off |off |If enabled, hides the property selector

diff --git a/src/chart/Utils.ts b/src/chart/Utils.ts
@@ -125,10 +125,10 @@ export const themeNivo = {
     legend: { text: { fill: 'rgb(var(--palette-neutral-text-default))' } },
   },
   legends: {
-    text: { fill: 'rgb(var(--palette-neutral-text-weak))' },
-    title: { text: { fill: 'rgb(var(--palette-neutral-text-weak))' } },
-    ticks: { text: { fill: 'rgb(var(--palette-neutral-text-weak))' } },
-    hidden: { text: { fill: 'rgb(var(--palette-neutral-text-weak))' } },
+    text: { fill: 'rgb(var(--palette-neutral-text-default))' },
+    title: { text: { fill: 'rgb(var(--palette-neutral-text-default))' } },
+    ticks: { text: { fill: 'rgb(var(--palette-neutral-text-default))' } },
+    hidden: { text: { fill: 'rgb(var(--palette-neutral-text-default))' } },
   },
   markers: {
     text: { fill: 'rgb(var(--palette-neutral-text-default))' },

diff --git a/src/chart/pie/PieChart.tsx b/src/chart/pie/PieChart.tsx
@@ -73,10 +73,10 @@ const NeoPieChart = (props: ChartProps) => {
   const settings = props.settings ? props.settings : {};
   const legendHeight = 20;
   // TODO to retrieve all defaults from the ReportConfig.ts file instead of hardcoding them in the file
-  const marginRight = settings.marginRight ? settings.marginRight : 24;
-  const marginLeft = settings.marginLeft ? settings.marginLeft : 24;
-  const marginTop = settings.marginTop ? settings.marginTop : 24;
-  const marginBottom = settings.marginBottom ? settings.marginBottom : 40;
+  const marginRight = settings.marginRight ? settings.marginRight : 50;
+  const marginLeft = settings.marginLeft ? settings.marginLeft : 50;
+  const marginTop = settings.marginTop ? settings.marginTop : 50;
+  const marginBottom = settings.marginBottom ? settings.marginBottom : 50;
   const sortByValue = settings.sortByValue ? settings.sortByValue : false;
   const enableArcLabels = settings.enableArcLabels !== undefined ? settings.enableArcLabels : true;
   const enableArcLinkLabels = settings.enableArcLinkLabels !== undefined ? settings.enableArcLinkLabels : true;

diff --git a/src/config/ReportConfig.tsx b/src/config/ReportConfig.tsx
@@ -606,22 +606,22 @@ export const REPORT_TYPES = {
       marginLeft: {
         label: 'Margin Left (px)',
         type: SELECTION_TYPES.NUMBER,
-        default: 24,
+        default: 50,
       },
       marginRight: {
         label: 'Margin Right (px)',
         type: SELECTION_TYPES.NUMBER,
-        default: 24,
+        default: 50,
       },
       marginTop: {
         label: 'Margin Top (px)',
         type: SELECTION_TYPES.NUMBER,
-        default: 24,
+        default: 50,
       },
       marginBottom: {
         label: 'Margin Bottom (px)',
         type: SELECTION_TYPES.NUMBER,
-        default: 40,
+        default: 50,
       },
       refreshButtonEnabled: {
         label: 'Refreshable',