This repository has been archived by the owner on Sep 3, 2021. It is now read-only.
Restructure test files #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@michaeldgraham according to `git blame` you wrote most of the "tck" tests. I have a hard time what "tck" actually means. Could you explain? Maybe: "Test Compatability Kit"? I find the name confusing. Could we * either use the unabbreviated name or * use another more descriptive name?
roschaefer
force-pushed
the
restructure_test_files
branch
from
eaaecea to
467cf17
Compare
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
=======================================
Coverage 94.47% 94.47%
=======================================
Files 4 4
Lines 326 326
=======================================
Hits 308 308
Misses 18 18Continue to review full report at Codecov.
|
With this commit you can run ``` npm run test-isolated ``` over and over again and the tests should pass. This does not fix the issue mentioned above but it makes it less painful. At least I can make my changes and run all tests exluding those that are not isolated. When I'm done with my changes I can re-import the data and run all the tests, even those that are not isolated. This is what I did to get all the tests passing on my machine: ``` sudo rm /var/lib/neo4j/data/databases/* -r sudo cp -rp ~/Downloads/temp/neo4j-graphql-js/recommendations.db/ /var/lib/neo4j/data/databases/graph.db sudo systemctl restart neo4j.service ``` Very annoying. @johnymontana @michaeldgraham do you know if there is a single command that brings the database into a state where it was *before* running the test case? Something that we could use in a `beforeEach` or `afterEach`? See: neo4j-graphql#252 (comment)
roschaefer
force-pushed
the
restructure_test_files
branch
from
9995597 to
2ed8ea3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See my commit messages for detailed explanation. As a summary, I don't see a point in using a glob pattern in
package.jsonwhen the documentation of ava clearly outlines the default pattern, see here. Aside that, I added one more script topackage.jsonwhich makes at least my life easier regarding #252.