Fixes #4321: support s3 for non-aws storage #4351
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4321
The test with a minio instance present here does not work as a "real" instance.
In fact, using an instance pointing to localhost, it fails with TODO error.
To fix it, just put the java property
Dcom.amazonaws.sdk.disableCertChecking=truethat executes the if present here.Therefore, added test and docs.
TestContainer considerations
Used bitnami/minio since the official minio image doesn't work in test container.
Using the official minio, it doesn't start without any error.
We should do: https://stackoverflow.com/questions/55402610/configuring-minio-server-for-use-with-testcontainers,
it works flakily in any case, sometimes throws an
Timeout waiting for result with exception ... Not ready yet.Moreover, it requires an additional container (
minio:mc), and additional code to create a bucket (sinceMINIO_DEFAULT_BUCKETSenv doesn't exist).Tried with TestContainer using a docker-compose as well, but without success.