Allow to get the native contract state without a projectSettings #3171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
changed the title
AnnaShaleva
approved these changes
Mar 3, 2024
| { | ||
| // Get allowed methods and nef script | ||
| NativeContractsCache.CacheEntry allowedMethods = GetAllowedMethods(settings, index); | ||
| var allowedMethods = GetAllowedMethods(hfChecker, index); |
There was a problem hiding this comment.
Just a question from my side: var-style variable declaration is a kind of accepted standard for this repo now? E.g. should we declare variables in the same way (with type omission)?
There was a problem hiding this comment.
I prefer Type x=new() but @Jim8y and @cschuchardt88 prefer this style
There was a problem hiding this comment.
Type x=new()
This way is more clear wrt variable types, and I see that a lot of old code support this way. OK.
There was a problem hiding this comment.
Well, I am not in any preference, I can accept any type, I just don't want to ban var. to be honest, I don't care about the style at all.
Jim8y
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It helps for neo-project/neo-devpack-dotnet#976
Allow to get the native contract state without having a
protocolSettings.