Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VM UT] update UT name #3115

Merged
merged 12 commits into from
Feb 7, 2024
Merged

[VM UT] update UT name #3115

merged 12 commits into from
Feb 7, 2024

Conversation

Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Feb 4, 2024

Description

This pr focus on standardize the UT file name and method name.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Just run the existing unit tests

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Jim8y and others added 5 commits February 5, 2024 12:30
@Jim8y @superboyiii
Update tests/Neo.VM.Tests/UT_StackItem.cs
9b4efd3 
Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>
@Jim8y @superboyiii
Update tests/Neo.VM.Tests/UT_StackItem.cs
ac514ae 
Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>
@Jim8y @superboyiii
Update tests/Neo.VM.Tests/UT_StackItem.cs
090c9ce 
Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>
@Jim8y @superboyiii
Update tests/Neo.VM.Tests/UT_StackItem.cs
9e7b0da 
Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>
@Jim8y @superboyiii
Update tests/Neo.VM.Tests/UT_StackItem.cs
201caf0 
Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>
@shargon @cschuchardt88
Update tests/Neo.VM.Tests/UT_ExecutionContext.cs
dbbc728 
Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>
shargon
shargon previously approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jim8y
Copy link
Contributor Author

Jim8y commented Feb 5, 2024 •
edited
Loading

@cschuchardt88 @NGDAdmin

@shargon
Copy link
Member

shargon commented Feb 5, 2024

Wait for merge to #3082 or it will produce conflicts

@shargon
Copy link
Member

shargon commented Feb 7, 2024

@Jim8y Conflicts

@Jim8y
Merge branch 'master' into vm-ut-name
e15df6c 
* master:
  Neo as dotnet standard (neo-project#3082)
@Jim8y
Copy link
Contributor Author

Jim8y commented Feb 7, 2024

@shargon good to go

@shargon shargon merged commit d65c198 into neo-project:master Feb 7, 2024
2 checks passed
@Jim8y Jim8y deleted the vm-ut-name branch February 7, 2024 11:46
Jim8y added a commit to Jim8y/neo that referenced this pull request Feb 7, 2024
@Jim8y
Merge branch 'master' into fix-tostring
2a74538 
* master:
  Related to neo-project#3082 (comment) (neo-project#3119)
  [VM UT] update UT name (neo-project#3115)
Jim8y added a commit to Jim8y/neo that referenced this pull request Feb 7, 2024
@Jim8y
Merge branch 'master' into optimize-vm
99e9c5f 
* master:
  Related to neo-project#3082 (comment) (neo-project#3119)
  [VM UT] update UT name (neo-project#3115)
  Neo as dotnet standard (neo-project#3082)
  Fix ut (neo-project#3113)
Jim8y added a commit to Jim8y/neo that referenced this pull request Feb 7, 2024
@Jim8y
Merge branch 'master' into neo-nullable
7a8b4bf 
* master:
  Related to neo-project#3082 (comment) (neo-project#3119)
  [VM UT] update UT name (neo-project#3115)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superboyiii superboyiii superboyiii left review comments

@cschuchardt88 cschuchardt88 cschuchardt88 approved these changes

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jim8y @shargon @cschuchardt88 @superboyiii @NGDAdmin