Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix| Signers not being set in neo-cli with Invoke Command #3090

Merged
merged 2 commits into from
Jan 14, 2024

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Jan 13, 2024

Description

Closes #3088

Basically signers are not being set in neo-cli when no sender or signers are specified. When command invoke is run. Set to use DefaultAccount of wallet.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

image

Test Configuration:
On TestNet
neo-cli: neo> invoke 0x70b53ba105de41678d0ffe57d62aa4cfd6e4e2db test

You need contract that calls syscall GetScriptContainer.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cschuchardt88 cschuchardt88 changed the title 'Bug' Fix #3088 Bug Fix| Signers not being set in neo-cli with Invoke Command Jan 13, 2024
@cschuchardt88
Copy link
Member Author

@vncoelho @superboyiii can you test?

Jim8y
Jim8y previously approved these changes Jan 13, 2024
@shargon shargon merged commit d018ccd into neo-project:master Jan 14, 2024
2 checks passed
@cschuchardt88 cschuchardt88 deleted the fix-signer-neo-cli branch January 14, 2024 13:46
@roman-khimov roman-khimov added this to the v3.7.0 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invoking Deployed Contracts in ApplicationEngine on Blockchain vs in neo-cli or local
4 participants