Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Devcontainer and link to codespace #3075

Merged
merged 7 commits into from
Jan 11, 2024
Merged

Adding Devcontainer and link to codespace #3075

merged 7 commits into from
Jan 11, 2024

Conversation

vncoelho
Copy link
Member

@vncoelho vncoelho commented Jan 9, 2024

With this simpler .devcontainer the project can be opened on codespace and everybody can develop and test things online.
Furthermore, it can help a quick setup on local environment as well.

To test this PR you can click on the link to codespace and pick the "devcontainer" branch, everything will be loaded.

@shargon
Copy link
Member

shargon commented Jan 10, 2024

Screenshot_20240110_102637_Chrome

@vncoelho we will need to install some dependencies

Co-authored-by: Shargon <shargon@gmail.com>
@vncoelho
Copy link
Member Author

Screenshot_20240110_102637_Chrome

@vncoelho we will need to install some dependencies

How can I reproduce this, @shargon ?

@shargon
Copy link
Member

shargon commented Jan 10, 2024

Screenshot_20240110_102637_Chrome

@vncoelho we will need to install some dependencies

How can I reproduce this, @shargon ?

I just tried to run neo-node

@vncoelho
Copy link
Member Author

Screenshot_20240110_102637_Chrome
@vncoelho we will need to install some dependencies

How can I reproduce this, @shargon ?

I just tried to run neo-node

This will be different in this case,
It was not yet prepared to run the node...aheuahuea

The first idea was just to introduce the devcontainer for developers to check code, verify tests and etc...
Run the node will probably require other image as well.

@vncoelho
Copy link
Member Author

Perfect,@shargon ,
So, lets merge this one and I will open another one for that purpose,which will probably require more discussions.

@shargon shargon merged commit 3d0d27e into master Jan 11, 2024
2 checks passed
@shargon shargon deleted the devcontainer branch January 11, 2024 18:39
@vncoelho
Copy link
Member Author

I will make some tests with neo-node now

@vncoelho
Copy link
Member Author

It is working, @shargon
Neo-cli is running here but the only problem is the need of LevelDb and its dependency sudo apt-get update && sudo apt-get -y install libleveldb-dev

@shargon
Copy link
Member

shargon commented Jan 12, 2024

It is working, @shargon Neo-cli is running here but the only problem is the need of LevelDb and its dependency sudo apt-get update && sudo apt-get -y install libleveldb-dev

You can configure it with memory store by default.

@vncoelho
Copy link
Member Author

It is working, @shargon Neo-cli is running here but the only problem is the need of LevelDb and its dependency sudo apt-get update && sudo apt-get -y install libleveldb-dev

You can configure it with memory store by default.

Exactly, what is the name we put on config ?

@cschuchardt88
Copy link
Member

cschuchardt88 commented Jan 12, 2024

@vncoelho MemoryStore or leave null and Path too.

@cschuchardt88
Copy link
Member

Looks like this a bug with it, looking to it

@cschuchardt88
Copy link
Member

cschuchardt88 commented Jan 12, 2024

@vncoelho Guess I wrong about null

This works

    "Storage": {
      "Engine": "MemoryStore",
      "Path": null,
    },

@cschuchardt88
Copy link
Member

Nope!! Its a bug with neo-cli

Jim8y added a commit to Jim8y/neo that referenced this pull request Jan 12, 2024
* master:
  Made `MemoryStore` the default whithout `config.json` for `neo-cli` (neo-project#3085)
  Adding Devcontainer and link to codespace (neo-project#3075)
  Update & Consolidate nugets (neo-project#3083)
  Adding NNS to `neo-cli` (neo-project#3032)
  Add: add pull request template (neo-project#3081)
  Move to monorepo: Neo.Cryptography.BLS12_381 (neo-project#3077)
  Add: add a new verify result status code (neo-project#3076)
  Convert to Neo.Json and Neo.ConsoleService to `dotnet` standard 2.1 (neo-project#3044)
  Avoid IsExternalInit  (neo-project#3079)
  Clean usings (neo-project#3078)
  Fixed asp.net core project (neo-project#3067)
  Updated BLS12_381 (neo-project#3074)
  avoid nonsense exception messages. (neo-project#3063)
  Removed `MyGet` (neo-project#3071)
  Updated unit-test (neo-project#3073)
  add hash verification for OnImport (neo-project#3070)
  Make public ReadUserInput (neo-project#3068)
  Removed asp.net core (neo-project#3065)
  Enforce Line Endings in `.editorconfig` (neo-project#3060)

# Conflicts:
#	src/Neo.CLI/CLI/MainService.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants