Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invokefunction #574

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Fix invokefunction #574

merged 2 commits into from
Mar 31, 2021

Conversation

shargon
Copy link
Member

@shargon shargon commented Mar 27, 2021

Close #573

@Qiao-Jin
Copy link
Contributor

Default MaxGasInvoke is 20. For the specified problem in #573, same error would still occur even with this PR patched. Maybe should also add a log reminding user to increase MaxGasInvoke in such cases?

neo-modules/src/RpcServer/RpcServer/config.json

Line 13 in e77f074

"MaxGasInvoke": 20,

@superboyiii superboyiii mentioned this pull request Mar 30, 2021
Closed
@superboyiii
Copy link
Member

I think it's OK, we can wait for @snowypowers 's response.

@shargon
Copy link
Member Author

shargon commented Mar 30, 2021

Maybe should also add a log reminding user to increase MaxGasInvoke in such cases?

Any error will be catched in line

https://github.com/neo-project/neo-modules/pull/574/files#diff-f4edf66b165030d591ad126a9d9a91daeed2f74df8c6aff0150a46fa193e5d4eR185

@snowypowers
Copy link
Member

Yes this should work out for my scenario. I forgot to mention I did set my config's MaxGasInvoke to 10000 so this fix will help me out!

@shargon shargon merged commit 571fb1c into neo-project:master Mar 31, 2021
@shargon shargon deleted the fix-invoke-gas branch March 31, 2021 08:16
joeqian10 pushed a commit to joeqian10/neo-modules that referenced this pull request Apr 7, 2021
@shargon @superboyiii @joeqian10
Fix (neo-project#574)
53b8733 
Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superboyiii superboyiii superboyiii approved these changes

@Qiao-Jin Qiao-Jin Qiao-Jin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invokefunction with open wallet has internal hardcoded GAS limit
4 participants
@shargon @Qiao-Jin @superboyiii @snowypowers