Inflow schema 300

[margrietpalm]

This is a pretty complex migration, as you can see on zenhub. One of the main issue is that all geometry columns should be not Null while before the migration these columns can be Null. Alembic doesn't allow migrating these Null columns to the new tables. So in general the workflow is as follows:

• Create new empty tables matching the new schema
• Modify existing table (v2_impervious_surface or v2_surface) such that all data that will be present in the new tables is already present
• Copy from modified table to new table

Question to the reviewer:

I did not implement tests for correctly copying the contents during the migration because of the complexity of this code. The chance of mistakes in the tests are as big as the chance of mistakes in the actual code. Any mistakes should be caught downstream when testing the simulatons; I hope.

[daanvaningen]

Nice work :) I tried following along using the excel sheet. But it is a bit difficult to follow and judge

As for your question, incorrect changes to the mapping of surfaces / dry weather flow will most likely be picked up by the testbank / regression tests.