Make friction_value in CrossSectionLocation table nullable #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CrossSectionDefinition.friction_values
can be present instead ofCrossSectionLocation.friction_value
. However, all nullable columns are automatically checked in https://github.com/nens/threedi-modelchecker/blob/master/threedi_modelchecker/config.py#L41. So to allow for the situation whereCrossSectionLocation.friction_value
isNone
andCrossSectionDefinition.friction_values
is defined,CrossSectionLocation.friction_value
needs to become nullable.The changes in the modelchecker related to this are here: nens/threedi-modelchecker@70f9393