Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make friction_value in CrossSectionLocation table nullable #51

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

margrietpalm
Copy link
Contributor

CrossSectionDefinition.friction_values can be present instead of CrossSectionLocation.friction_value. However, all nullable columns are automatically checked in https://github.com/nens/threedi-modelchecker/blob/master/threedi_modelchecker/config.py#L41. So to allow for the situation where CrossSectionLocation.friction_value is None and CrossSectionDefinition.friction_values is defined, CrossSectionLocation.friction_value needs to become nullable.

The changes in the modelchecker related to this are here: nens/threedi-modelchecker@70f9393

Copy link
Contributor

@elisalle elisalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tried running the new migration but it looks good. Just the changelog still needs updating and it should be good to go.

@margrietpalm
Copy link
Contributor Author

Thanks @elisalle. Changelog is now updated

@wduizer wduizer reopened this Jan 25, 2024
@margrietpalm margrietpalm merged commit 98ce94a into master Jan 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants