Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added parameters for variable friction and 1D vegetation #50

Merged
merged 5 commits into from
Jan 8, 2024
Merged

Added parameters for variable friction and 1D vegetation #50

merged 5 commits into from
Jan 8, 2024

Conversation

margrietpalm
Copy link
Contributor

@margrietpalm margrietpalm commented Dec 21, 2023 •
edited
Loading

Note that I created the migration without using alembic. All tests pass, but I'm not sure if I missed things by not using alembic.

@margrietpalm margrietpalm marked this pull request as draft December 21, 2023 13:22
@margrietpalm margrietpalm marked this pull request as ready for review December 21, 2023 13:38
@margrietpalm margrietpalm marked this pull request as draft December 21, 2023 13:57
@margrietpalm margrietpalm self-assigned this Dec 22, 2023
@margrietpalm margrietpalm marked this pull request as ready for review December 22, 2023 07:52
elisalle
elisalle approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@elisalle elisalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good; I tried migrating a database using the migration and all the columns were correctly added.
Has Leendert said whether the columns should be beta features?

@margrietpalm margrietpalm linked an issue Jan 4, 2024 that may be closed by this pull request
Variable friction and 1D vegetation parameters #42
Closed
@margrietpalm margrietpalm marked this pull request as draft January 8, 2024 07:04
@margrietpalm margrietpalm marked this pull request as ready for review January 8, 2024 07:18
@margrietpalm
Copy link
Contributor Author

@elisalle I commited some changes requested by Golnesa: #42 (comment)

@margrietpalm margrietpalm merged commit fdc1a37 into master Jan 8, 2024
5 checks passed
@margrietpalm margrietpalm deleted the mpalm/42-vfric-1dveg-pars branch January 8, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elisalle elisalle elisalle approved these changes

Assignees

@margrietpalm margrietpalm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Variable friction and 1D vegetation parameters
2 participants
@margrietpalm @elisalle