Fix problem with culvert geom migration in 228 #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename sqlite table "tags" to "tag" * Remove indices referring to removed tables in previous migrations * Make model_settings.use_2d_rain and model_settings.friction_averaging booleans * Remove columns referencing v2 in geometry_column * Ensure correct use_* values when matching tables have no data * Use custom types for comma separated and table text fields to strip extra white space * Correct direction of dwf and surface map * Remove v2 related views from sqlite
|
Closed because this should be hotfix for 228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure if this is a real issue, but I ran into it while testing with some of the standard schematisations I used before. Turned out that
v2_culvert.the_geomis not always a proper linestring in all sample schematisations. This change should fix that.