Use class name of a network if it is more informative #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @tcstewar @krisfrenette |
5 tasks
|
Ping @tcstewar @krisfrenette |
tcstewar
approved these changes
Oct 17, 2019
There was a problem hiding this comment.
The more I think about this proposal, the happier I am with it... I was initially very hesitant to move away from my original plan of "default labels are always valid python strings that will get you to the object".... But that principle really hasn't been all that useful, and so I now rather like this simple idea here.
jgosmann
added a commit
to nengo/nengo-spa
that referenced
this pull request
Oct 19, 2019
Addresses #234. Made possible with the merge of nengo/nengo-gui#1002.
4 tasks
jgosmann
added a commit
to nengo/nengo-spa
that referenced
this pull request
Nov 18, 2019
Addresses #234. Made possible with the merge of nengo/nengo-gui#1002.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements my proposal from #1000. I think this is an improvement and would enable Nengo SPA to not set the label for networks and give better names to SPA objects when no explicit label is given.