Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable caching in setup action #198

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Add option to disable caching in setup action #198

merged 2 commits into from
Feb 28, 2024

Conversation

drasmuss
Copy link
Member

No description provided.

Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Member

@tbekolay tbekolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cache:
description: Enable/disable caching of pip/conda downloads
required: false
default: "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My gut reaction is to make this of type boolean and remove the quotes, but from looking at mamba-org/setup-micromamba it seems they don't set a type so I would assume that defaults to string.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I thought at first, but turns out you can't actually have boolean input types for composite actions (see actions/runner#2238).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

@drasmuss drasmuss merged commit 01e4432 into main Feb 28, 2024
12 checks passed
@drasmuss drasmuss deleted the cache-option branch February 28, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants