-
-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for PHPUnit 6 #707
Conversation
hboomsma
commented
Mar 23, 2017
- Made PHPUnit a dev requirement (no dependencies on PHPUnit in the src folder)
- Allow for installing PHPUnit 6
- As Soon as the Symfony PHPunit bridge is released you'll get 6 on PHP 7.0
- Made @Covers use FQCN's (as is the case in master)
- Removed old mock framework calls
- Added testcases for the only 2 tests marked as Risky by PHPUnit 6
* Made PHPUnit a dev requirement (no dependencies on PHPUnit in the src folder) * Allow for installing PHPUnit 6 * As Soon as the Symfony PHPunit bridge is released you'll get 6 on PHP 7.0 * Made @Covers use FQCN's (as is the case in master) * Removed old mock framework calls * Added testcases for the only 2 tests marked as Risky by PHPUnit 6
That was clearly a mistake. As nelmio/alice is usually a dev dependency hopefully this will not have caused much harm though. Thanks :) |
@theofidry can you make a new 2.3.1 release to avoid forcing installing PHPUnit when using alice ? |
I'll do it. If it's not done in the next 2h ping me on Slack
…On Fri, 14 Apr 2017 at 13:19, Christophe Coevoet ***@***.***> wrote:
@theofidry <https://github.com/theofidry> can you make a new 2.3.1
release to avoid forcing installing PHPUnit when using alice ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#707 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AE76gSyR8_6vmg5WE-wksbulOnKGsuWqks5rv2RbgaJpZM4MmW6u>
.
|
done* |
thanks |
actually, Packagist does not yet know it, while it found 3.0 beta 5. @Seldaek can you check whether Packagist triggered an error (or just force an update) ? |
Damn, it's the second time it's happening. @Seldaek could that be the hooks not working correctly? Otherwise maybe add me on packagist as well so that I can do a force update. |
Should be ok now @stof :) |
thanks |