Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for PHPUnit 6 #707

Merged
merged 1 commit into from
Mar 23, 2017
Merged

Prepare for PHPUnit 6 #707

merged 1 commit into from
Mar 23, 2017

Conversation

hboomsma
Copy link

  • Made PHPUnit a dev requirement (no dependencies on PHPUnit in the src folder)
  • Allow for installing PHPUnit 6
  • As Soon as the Symfony PHPunit bridge is released you'll get 6 on PHP 7.0
  • Made @Covers use FQCN's (as is the case in master)
  • Removed old mock framework calls
  • Added testcases for the only 2 tests marked as Risky by PHPUnit 6

* Made PHPUnit a dev requirement (no dependencies on PHPUnit in the src folder)
* Allow for installing PHPUnit 6
* As Soon as the Symfony PHPunit bridge is released you'll get 6 on PHP 7.0
* Made @Covers use FQCN's (as is the case in master)
* Removed old mock framework calls
* Added testcases for the only 2 tests marked as Risky by PHPUnit 6
@theofidry theofidry merged commit b428491 into nelmio:2.x Mar 23, 2017
@theofidry
Copy link
Member

Made PHPUnit a dev requirement (no dependencies on PHPUnit in the src folder)

That was clearly a mistake. As nelmio/alice is usually a dev dependency hopefully this will not have caused much harm though.

Thanks :)

@hboomsma hboomsma deleted the 2.x_phpunit6 branch March 23, 2017 09:06
@stof
Copy link
Contributor

stof commented Apr 14, 2017

@theofidry can you make a new 2.3.1 release to avoid forcing installing PHPUnit when using alice ?

@theofidry
Copy link
Member

theofidry commented Apr 14, 2017 via email

@theofidry
Copy link
Member

done*

@stof
Copy link
Contributor

stof commented Apr 14, 2017

thanks

@stof
Copy link
Contributor

stof commented Apr 14, 2017

actually, Packagist does not yet know it, while it found 3.0 beta 5.

@Seldaek can you check whether Packagist triggered an error (or just force an update) ?

@theofidry
Copy link
Member

Damn, it's the second time it's happening. @Seldaek could that be the hooks not working correctly? Otherwise maybe add me on packagist as well so that I can do a force update.

@theofidry
Copy link
Member

Should be ok now @stof :)

@stof
Copy link
Contributor

stof commented Apr 15, 2017

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants