Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecations #1157

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Fix deprecations #1157

merged 1 commit into from
Dec 2, 2023

Conversation

jderusse
Copy link
Contributor

@jderusse jderusse commented Nov 30, 2023 •
edited
Loading

This PR fixes the below deprecations:

Deprecated: Optional parameter $resolver declared before required parameter $context is implicitly treated as a required parameter in /srv/api/vendor/nelmio/alice/src/Generator/Resolver/Parameter/Chainable/StringParameterResolver.php on line 91

Deprecated: Optional parameter $flags declared before required parameter $value is implicitly treated as a required parameter in /srv/api/vendor/nelmio/alice/src/FixtureBuilder/Denormalizer/Fixture/SpecificationBagDenormalizer/Value/UniqueValueDenormalizer.php on line 47

Deprecated: Optional parameter $flags declared before required parameter $value is implicitly treated as a required parameter in /srv/api/vendor/nelmio/alice/src/FixtureBuilder/Denormalizer/Fixture/SpecificationBagDenormalizer/ValueDenormalizerInterface.php on line 33

Deprecated: Optional parameter $flags declared before required parameter $value is implicitly treated as a required parameter in /srv/api/vendor/nelmio/alice/src/FixtureBuilder/Denormalizer/Fixture/SpecificationBagDenormalizer/Value/SimpleValueDenormalizer.php on line 40

note: This can't be a BC break as the parameter is required (see the PHP deprecation message, and also POC )

@theofidry theofidry merged commit 1141bf4 into nelmio:master Dec 2, 2023
8 checks passed
@theofidry
Copy link
Member

Thank you @jderusse

theofidry added a commit to theofidry/alice that referenced this pull request Dec 2, 2023
@theofidry
fix: Address the PHP 8.2 deprecations
9d3f8ad 
Follow up of nelmio#1157.
@theofidry theofidry mentioned this pull request Dec 2, 2023
Merged
theofidry added a commit that referenced this pull request Dec 2, 2023
@theofidry
fix: Address the PHP 8.2 deprecations (#1158)
e98f2c4 
Follow up of #1157.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jderusse @theofidry