Add Symfony 6.0 support #1099
Merged
Add Symfony 6.0 support #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR looks okay. @theofidry Could you please approve the awaiting workflows? Thanks! |
theofidry
approved these changes
Dec 9, 2021
|
Thank you @javer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Symfony 6.0 support and fixes tests with Symfony 5.4.
Please note that it requires PHP version bump to 8.0, because
symfony/property-accesssince 6.0 has declared return types, and we have to declare them too, and one of them ismixedwhich is supported only since PHP 8.0.