Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #15 #17

Merged
merged 1 commit into from
May 21, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mesmerize_core/caiman_extensions/cnmf.py
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def get_spatial_contour_coors(self, ixs_components: np.ndarray) -> List[np.ndarr
return coordinates

@validate('cnmf')
def get_temporal_components(self, ixs_components: np.ndarray = None, add_background: bool = True) -> np.ndarray:
def get_temporal_components(self, ixs_components: np.ndarray = None, add_background: bool = False) -> np.ndarray:
"""
Get the temporal components for this CNMF item

Expand Down Expand Up @@ -231,4 +231,4 @@ def get_reconstructed_movie(self, ixs_frames: Tuple[int, int] = None, add_backgr

if add_background:
dn += (cnmf_obj.estimates.b.dot(cnmf_obj.estimates.f[:, ixs_frames[0]:ixs_frames[1]]))
return dn.reshape(cnmf_obj.dims + (-1,), order='F').transpose([2, 0, 1])
return dn.reshape(cnmf_obj.dims + (-1,), order='F').transpose([2, 0, 1])