Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install sh usage #2454

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Fix install sh usage #2454

merged 4 commits into from
Sep 19, 2024

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Sep 10, 2024

closes #2453

@jsoref jsoref requested a review from a team as a code owner September 10, 2024 22:19
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.70%. Comparing base (5a80a04) to head (04c85b2).
Report is 111 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2454       +/-   ##
===========================================
+ Coverage   61.56%   76.70%   +15.14%     
===========================================
  Files          53       62        +9     
  Lines        9002     8186      -816     
===========================================
+ Hits         5542     6279      +737     
+ Misses       3020     1343     -1677     
- Partials      440      564      +124     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with changing this file.

On the other hand this could be deleted as well in my opinion as deprecated left over

@mergify mergify bot merged commit be89cbc into nektos:master Sep 19, 2024
12 checks passed
@jsoref jsoref deleted the fix-install-sh-usage branch September 19, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

usage generated by godownloader is wrong
3 participants