Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage special bash options when no shell is defined in a workflow #2449

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Manage special bash options when no shell is defined in a workflow #2449

merged 1 commit into from
Sep 19, 2024

Conversation

sebastien-perpignane
Copy link
Contributor

Fixes #2448

@sebastien-perpignane sebastien-perpignane requested a review from a team as a code owner September 10, 2024 20:30
@sebastien-perpignane sebastien-perpignane force-pushed the bugfix/issue2448-bash-options branch 2 times, most recently from d9ea33a to 3a9d402 Compare September 12, 2024 22:07
@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 12, 2024
@sebastien-perpignane sebastien-perpignane changed the title Remove "-o pipefail" from bash options Manage special bash options when no shell is defined in a workflow Sep 12, 2024
wolfogre
wolfogre previously approved these changes Sep 13, 2024
View reviewed changes
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 13, 2024

@sebastien-perpignane this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Sep 13, 2024
ChristopherHX
ChristopherHX reviewed Sep 13, 2024
View reviewed changes
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint error would need to be fixed

--Error detail:
 pkg/model/workflow.go:
 	623: Wrong indentation type(spaces instead of tabs)
 	625: Wrong indentation type(spaces instead of tabs)

E.g. the vscode extention for go automatically fixes this kind of errors

Broken Tests whatever they test


--- FAIL: TestRunEvent/defaults-run (3.95s)
=== RUN   TestStepRun
--- FAIL: TestStepRun (0.04s)

pkg/model/workflow.go Outdated Show resolved Hide resolved
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 14, 2024

@sebastien-perpignane this pull request has failed checks 🛠

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 14, 2024

@sebastien-perpignane this pull request has failed checks 🛠

@sebastien-perpignane sebastien-perpignane force-pushed the bugfix/issue2448-bash-options branch 2 times, most recently from 175185c to 0af3f8b Compare September 15, 2024 06:22
@sebastien-perpignane
bug/issue nektos#2448 - manage special bash options when no shell is …
b87c8e4 
…defined

* bash without "-o pipefail" option when "bash" is not explicitely
defined in the workflow
* bonus: fix inverted expected and actual in TestGetGitHubContext assertions
@codecov Codecov
Copy link

codecov bot commented Sep 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.66%. Comparing base (5a80a04) to head (b87c8e4).
Report is 110 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #2449       +/-   ##
===========================================
+ Coverage   61.56%   76.66%   +15.10%     
===========================================
  Files          53       62        +9     
  Lines        9002     8186      -816     
===========================================
+ Hits         5542     6276      +734     
+ Misses       3020     1345     -1675     
- Partials      440      565      +125

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot removed the needs-work Extra attention is needed label Sep 15, 2024
@mergify mergify bot requested a review from a team September 15, 2024 08:16
ChristopherHX
ChristopherHX approved these changes Sep 15, 2024
View reviewed changes
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finishing this looks good to me

I also never wrote anything in go, until modding the existing nektos/act

@sebastien-perpignane
Copy link
Contributor Author

Thanks for finishing this looks good to me

I also never wrote anything in go, until modding the existing nektos/act

are we waiting for @wolfogre approval before merging ?

@ChristopherHX
Copy link
Contributor

...Yes, or cplee (owner). Automerge for you only with all checks green + 2 approvals (maintainer+owner)

A big regressions must have been merged for me to bypass this here, since I'm not an owner.

@mergify mergify bot merged commit 2e117a4 into nektos:master Sep 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfogre wolfogre wolfogre approved these changes

@ChristopherHX ChristopherHX ChristopherHX approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manage special bash options when no shell is defined in a workflow
3 participants
@sebastien-perpignane @ChristopherHX @wolfogre