Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: artifact v4 upload above 8MB #2402

Merged
merged 3 commits into from
Sep 7, 2024
Merged

Conversation

ChristopherHX
Copy link
Contributor

Multiple chunks are uploaded with type "block" without using "appendBlock", my .net Implementation didn't have different handling for these upload type and this solves the issue for act itself

8MB seems to be the chunk size

Closes #2351
Closes #2371

@ChristopherHX ChristopherHX requested a review from a team as a code owner July 20, 2024 12:35
Copy link
Contributor

github-actions bot commented Jul 20, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY gitleaks yes no 2.32s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 8.21s
✅ REPOSITORY secretlint yes no 1.0s
✅ REPOSITORY trivy-sbom yes no 0.49s
✅ REPOSITORY trufflehog yes no 4.36s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.62%. Comparing base (5a80a04) to head (0ff30c5).
Report is 105 commits behind head on master.

Files with missing lines Patch % Lines
pkg/artifacts/arifacts_v4.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2402       +/-   ##
===========================================
+ Coverage   61.56%   76.62%   +15.06%     
===========================================
  Files          53       62        +9     
  Lines        9002     8164      -838     
===========================================
+ Hits         5542     6256      +714     
+ Misses       3020     1343     -1677     
- Partials      440      565      +125     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristopherHX ChristopherHX marked this pull request as draft July 20, 2024 15:14
@ChristopherHX
Copy link
Contributor Author

gitea still has problems in this case, but it could be act doesn't have shown this issue because of less database acceses

Investigating using the blocklist at least for gitea

@ChristopherHX
Copy link
Contributor Author

I don't have any plans for further improvements like done for Gitea in act.
I'm removing the draft status as this can make uploads above 8MB more likely a success, but potentially not always.

@ChristopherHX ChristopherHX marked this pull request as ready for review August 30, 2024 20:55
@mergify mergify bot merged commit 32b6bb7 into master Sep 7, 2024
12 checks passed
@mergify mergify bot deleted the fix-artifact-v4-upload-above-8MB branch September 7, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants