Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add riscv64 binary release #2350

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Add riscv64 binary release #2350

merged 1 commit into from
Jun 5, 2024

Conversation

mengzhuo
Copy link
Contributor

@mengzhuo mengzhuo commented Jun 4, 2024

For #2347

@mengzhuo mengzhuo requested a review from a team as a code owner June 4, 2024 08:38
@codecov Codecov
Copy link

codecov bot commented Jun 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.29%. Comparing base (5a80a04) to head (85909b5).
Report is 77 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #2350       +/-   ##
===========================================
+ Coverage   61.56%   76.29%   +14.72%     
===========================================
  Files          53       61        +8     
  Lines        9002     7803     -1199     
===========================================
+ Hits         5542     5953      +411     
+ Misses       3020     1295     -1725     
- Partials      440      555      +115

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ChristopherHX
ChristopherHX previously approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, you still need another review

install.sh Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tool used to generate this is deprecated as of Jan 14, 2022, so no problem to change this from my side

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

@pull-request-size pull-request-size bot added size/XS and removed size/S labels Jun 4, 2024
@mergify mergify bot requested a review from a team June 4, 2024 09:41
@mergify mergify bot merged commit 55a8f9a into nektos:master Jun 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cplee cplee cplee approved these changes

@ChristopherHX ChristopherHX ChristopherHX approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mengzhuo @cplee @ChristopherHX