Fix copy of hiera data files #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It also ends up copying hiera data files to C:/var/lib/ instead of C:/var/lib/hiera on windows...
|
thanks for this. i will merge, test and release shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this code is redundant...
On windows, hiera data files end up being copied to
C:/var/lib/instead ofC:/var/lib/hierawhenhiera_data_remote_pathis set to/var/lib/hiera. (I suspect becauseC:/var/lib/hieradoes not exist by default)With this change, the
C:/var/lib/hierafolder is created before the copy and files do end up being copied toC:/var/lib/hiera.Not sure why there is special logic that skip creating
/var/lib/hierain the first place?