Use expand_path to set absolute path for puppetfile_path #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks! :) |
|
Awesome, thanks :) On 22 Oct 2016 6:53 pm, "Neill Turner" notifications@github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #85
We were experiencing the same issue as the OP, and it turns out it was because the
puppetfile_pathconfig wasn't referencing an absolute path. Once this was changed, relocating thePuppetfiletospec/fixtures(or any other path) works as expected.This change will work fine with existing implementations, as
File.expand_pathwill be a noop on the defaultpuppetfile_path, as that is already an absolute path.