Skip to content
This repository has been archived by the owner on Jul 10, 2020. It is now read-only.

Ability to show label in inline-form including change from \r\n to \n #190

Merged
merged 3 commits into from
Jan 29, 2017
Merged

Ability to show label in inline-form including change from \r\n to \n #190

merged 3 commits into from
Jan 29, 2017

Conversation

alexz707
Copy link

HI! as already discussed I have made a PR.

Before I could write the new feature I had to change the tests.
Please check if they work on your system (I guess you use windows ;) ) too.

Regards!

@coveralls
Copy link

coveralls commented Jan 28, 2017

Coverage Status

Coverage increased (+0.02%) to 89.877% when pulling 87ec981 on alexz707:master into 6c762a9 on neilime:master.

@neilime
Copy link
Owner

neilime commented Jan 29, 2017

Thank you for this pull request.

Please, can you change this :

  • The option "showLabel" should be defined in the option array, not in the "label_attributes".
    "label_attributes" is dedicated to set attributes ("class", "id"...) to the <label> element.

Thanks

@alexz707
Copy link
Author

Hope the readme is acceptable.

@coveralls
Copy link

coveralls commented Jan 29, 2017

Coverage Status

Coverage increased (+0.02%) to 89.877% when pulling ed42211 on alexz707:master into 6c762a9 on neilime:master.

@neilime neilime merged commit 7bfa5ad into neilime:master Jan 29, 2017
@neilime
Copy link
Owner

neilime commented Jan 29, 2017

Perfect ! Thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants