Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow reserved characters #965

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Conversation

aaperis
Copy link
Contributor

@aaperis aaperis commented Jul 30, 2024

Related issue(s) and PR(s)
This PR closes #396

Description

  • Checks upload filepath for reserved characters and throws an informative error message if any is found.
  • The testsuite is expanded to check all disallowed character cases.

How to test
go test

@aaperis aaperis self-assigned this Jul 30, 2024
@aaperis aaperis requested a review from a team July 30, 2024 11:31
jbygdell
jbygdell previously approved these changes Jul 31, 2024
@jbygdell jbygdell enabled auto-merge July 31, 2024 06:16
sda/cmd/s3inbox/proxy.go Outdated Show resolved Hide resolved
pontus
pontus previously approved these changes Jul 31, 2024
MalinAhlberg
MalinAhlberg previously approved these changes Jul 31, 2024
@aaperis aaperis dismissed stale reviews from MalinAhlberg, pontus, and jbygdell via 268d923 July 31, 2024 09:29
@aaperis aaperis requested review from a team, pontus, MalinAhlberg and jbygdell July 31, 2024 09:30
@jbygdell jbygdell added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit b203446 Jul 31, 2024
24 checks passed
@jbygdell jbygdell deleted the feat/disallow-reserved-characters branch July 31, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[s3inbox] check for reserved characters in upload path
4 participants