Feature/api keys

[kostas-kou]

Related issue(s) and PR(s)
This PR closes #1036.

Description
With this PR an endpoint for adding key hash in added in the api service.
An extra step of adding an api role in the database was necessary in order to make it work.

• payload is a public key file as base64 encoded string i.e base64 -w0 c4gh.pub.pem
• Validation is done to ensure that:
  • payload is base64 encoded
  • payload is a cryp4gh public file
• Integration tests have been expanded to:
  • add public key has to the database, twice so we also check the error.
  • validate that the hash in the database is identical to the manually computed hash.

How to test
From the root of the folder run make build-all
and then for linux run:

PR_NUMBER=$(/usr/bin/date '+%F')  docker compose -f .github/integration/sda-s3-integration.yml run integration_test

while for mac run:

PR_NUMBER=$(/bin/date '+%F')  docker compose -f .github/integration/sda-s3-integration.yml run integration_test

Then set the token as envvar: export ACCESS_TOKEN=$(curl -s -k http://localhost:8080/tokens | jq -r '.[0]')
and run:

curl -H "Authorization: Bearer $ACCESS_TOKEN" -H "Content-Type: application/json" -X POST -d '{"pubkey": "'"$(base64 -w0 PATH_TO_PUBKEY_FILE)"'", "description": "this is the key description"}' http://localhost:8090/c4gh-keys/add

Confirm that the key hash is in the database by running: docker exec -it postgres psql -U postgres -d sda and then the query select * from sda.encryption_keys;

[MalinAhlberg]

Good work! I agree with @jbygdell that it would be very nice, and much more user friendly, if the user could just send the public key and then the api would calculate the hex.
Apart from that it looks good and works with the mentioned tests coming in #1073 .

[nanjiangshu]

Great work! Works well when I tested and I just left a few minor comments.

Apart from that, I find that when trying to insert an already existing key, it takes more than 60 seconds to return the response. I guess this is caused by repeated retrying to insert the key? Would be great if the check of the existence a key can be done at an earlier stage so that the user don't need to wait 60 seconds to get the error message.

[MalinAhlberg]

it takes more than 60 seconds to return the response.

Great catch @nanjiangshu! I was wondering why the integrations tests were even slower than usual 😅

[MalinAhlberg]

Great!

[nanjiangshu]

Looks good!