Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to add/replace headers when doing header re-encryption #128

Merged
merged 5 commits into from
Mar 22, 2024

Conversation

pontus
Copy link
Contributor

@pontus pontus commented Mar 7, 2024

Allow passing of zero or more EncryptedHeaderPacket that will be added to the reencrypted header by ReEncryptHeader. If a packet of the same type exists already it will be replaced.

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.44%. Comparing base (608c142) to head (5bd7dd8).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   71.21%   72.44%   +1.22%     
==========================================
  Files           6        6              
  Lines         886      900      +14     
==========================================
+ Hits          631      652      +21     
+ Misses        135      129       -6     
+ Partials      120      119       -1     
Flag Coverage Δ
unittests 72.44% <100.00%> (+1.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pontus pontus requested a review from a team March 7, 2024 08:03
@blankdots blankdots requested a review from a team March 8, 2024 05:34
model/headers/headers_test.go Outdated Show resolved Hide resolved
model/headers/headers_test.go Outdated Show resolved Hide resolved
model/headers/headers_test.go Outdated Show resolved Hide resolved
model/headers/headers_test.go Outdated Show resolved Hide resolved
streaming/streaming_test.go Outdated Show resolved Hide resolved
pontus and others added 4 commits March 11, 2024 10:16
Allow passing of zero or more EncryptedHeaderPacket that will be added
to the reencrypted header by ReEncryptHeader. If a packet of the same type
exists already it will be replaced.
Co-authored-by: Joakim Bygdell <j.bygdell@gmail.com>
@pontus pontus force-pushed the support_header_additions branch 3 times, most recently from f296ec1 to 4049375 Compare March 11, 2024 09:27
@pontus pontus requested a review from jbygdell March 11, 2024 13:10
@blankdots blankdots requested a review from a team March 12, 2024 17:59
@blankdots blankdots merged commit 11e907a into master Mar 22, 2024
6 checks passed
@blankdots blankdots deleted the support_header_additions branch March 22, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants