Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when seeking in a non-seekable source stream leading to boundary crossings. #109

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

pontus
Copy link
Contributor

@pontus pontus commented Jan 19, 2024

This fixes a bug where the position in the underlying data stream was not properly updated when seeking forward in a non-seekable stream, which could lead to incorrect data returned. A related possible issue with delayed update of stream position after read is also fixed.

This PR also makes almost all test run for both seekable and non-seekable data source streams.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b63ead) 66.46% compared to head (a6128d8) 65.85%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   66.46%   65.85%   -0.62%     
==========================================
  Files           6        6              
  Lines        1184     1186       +2     
==========================================
- Hits          787      781       -6     
- Misses        278      284       +6     
- Partials      119      121       +2     
Flag Coverage Δ
unittests 65.85% <100.00%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dbampalikis dbampalikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Tested with the sda-download and fixes that issue too!

Copy link
Contributor

@aaperis aaperis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@aaperis aaperis merged commit 9f9735d into master Jan 19, 2024
6 checks passed
@aaperis aaperis deleted the position_fix branch January 19, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants