Add some tests of EOF handling #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #107 +/- ##
=======================================
Coverage 65.85% 65.85%
=======================================
Files 6 6
Lines 1186 1186
=======================================
Hits 781 781
Misses 284 284
Partials 121 121
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jbygdell
approved these changes
Jan 11, 2024
blankdots
approved these changes
Jan 19, 2024
|
@pontus shall we merge this as well? |
|
I just pushed a fix to align with other tests (check everything for both seekable and non-seekable). Can be merged directly if it passes review again. |
blankdots
approved these changes
Jan 19, 2024
teemukataja
approved these changes
Jan 22, 2024
jbygdell
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully succeed when #106 is merged.