Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move default model to gpt-4o-mini #91

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

PeterDaveHello
Copy link
Contributor

@negoziator as you requested 😏

@negoziator
Copy link
Owner

@PeterDaveHello Thank you 😄

@@ -83,7 +83,7 @@ aicommit config set <key>=<value>
| `OPENAI_KEY` | N/A | The OpenAI API key. |
| `locale` | `en` | Locale for the generated commit messages. |
| `generate` | `1` | Number of commit messages to generate. |
| `model` | `gpt-3.5-turbo` | The Chat Completions model to use. |
| `model` | `gpt-4o-mini` | The Chat Completions model to use. |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PeterDaveHello I think this model should be gpt-4o according to the current supported models

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand. It's quite clear:

As of July 2024, gpt-4o-mini should be used in place of gpt-3.5-turbo, as it is cheaper, more capable, multimodal, and just as fast. gpt-3.5-turbo is still available for use in the API.

https://platform.openai.com/docs/models/gpt-3-5-turbo

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely agree with you - and i wish i could use the -mini , but as far as i can see it's only the -4o that is supported right now in their dictionary ?

Let me know if i'm misunderstanding something :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any dependency on the repo you mentioned? I don't know why it's relevant.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is what you mean:

"@dqbd/tiktoken": "^1.0.2"

Then we should wait for dqbd/tiktoken#112. Otherwise, I don't understand why you asked me to open a PR here.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are absolutely right 👍🏼

Copy link
Contributor Author

@PeterDaveHello PeterDaveHello Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe using the official openai-node lib will prevent similar issues in the feature because they already supported gpt-4o-mini?

openai/openai-node#942

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PeterDaveHello Good point. I will remove the dependency as it gives no value 😄

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you update your branch now - i think it should work :)

@negoziator negoziator merged commit ffcd889 into negoziator:master Jul 30, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants