fix: handle undefined for aspect ratio #2561
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AspectRatio can technically be passed as
undefined
in the stylesheet and that is handled on ios/android.Passing
undefined
toaspectRatio
on web leads to the following error:TypeError: Cannot read properties of undefined (reading 'toString')
While it does not make sense as to why you might explicitly want to pass undefined to aspectRatio, my use case is that I had a custom component that was setting the aspectRatio as well as accepting styles prop that overrides the defined styles so I had to pass undefined for aspectRatio. This works fine or ios/android but crashed on web.
I also added a test case