feat: shadow root support #2138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there was a similar issue with rendering into sourceless iframes. Perhaps this patch could be adapted to include support for that use case too? |
|
And it's possible this overlaps with the issue for using multiple windows (i.e., roots) in an electron environment #1765 |
|
@jon-w1 following up on the comments above. Thanks |
Here I am creating a fix for multiple windows/iframes https://github.com/zarubond/react-native-web/tree/zarubond/multi_root |
7 tasks
necolas
added a commit
that referenced
this pull request
Mar 2, 2022
* Improves React Native compatibility by making StyleSheet.create the identify function. * Improves React 18 support by inserting styles on eval. * Supports use with multiple windows (i.e., iframes) and shadow roots. * Supports nested LTR/RTL layouts. * Supports 3rd party compilers and extraction to static CSS. * Fixes static and dynamic short/longform deduplication. * Reduces browser support: Safari 10.1+, Chromium Edge, no IE, no legacy Android browsers. * Removes automatic vendor-prefixing of inline styles (for better perf). * Removes focus-visible polyfill as modern browsers no longer show focus rings for mouse interactions. Close #2208 Fix #2138 Fix #2196 Fix #2007 Fix #1517
Merged
rnike
pushed a commit
to VeryBuy/react-native-web
that referenced
this pull request
Sep 13, 2022
* Improves React Native compatibility by making StyleSheet.create the identify function. * Improves React 18 support by inserting styles on eval. * Supports use with multiple windows (i.e., iframes) and shadow roots. * Supports nested LTR/RTL layouts. * Supports 3rd party compilers and extraction to static CSS. * Fixes static and dynamic short/longform deduplication. * Reduces browser support: Safari 10.1+, Chromium Edge, no IE, no legacy Android browsers. * Removes automatic vendor-prefixing of inline styles (for better perf). * Removes focus-visible polyfill as modern browsers no longer show focus rings for mouse interactions. Close necolas#2208 Fix necolas#2138 Fix necolas#2196 Fix necolas#2007 Fix necolas#1517
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Importing
react-native-webkicks offStyleSheetresolution on a singlestyleelement which gets added to theheadof the HTML document. However, when rendering an application within a Shadow DOM root (e.g. when encapsulating within an HTML custom element), any stylesheets from the maindocumentare ignored.Issue Link
#1517
In This Update
renderApplicationto check if therootTag'sRootNodeis ofShadowRoottype. If so, an additionalstyletag is added to the shadow rootcreateStyleResolverto insert any new rules into both the document-level stylesheet as well as any additional shadow root stylesheetsThis is my first PR for RNW so let me know if there's anything else I should consider!