Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Modal Dialogs #1646

Closed
wants to merge 76 commits into from
Closed

Support Modal Dialogs #1646

wants to merge 76 commits into from

Commits on Aug 12, 2020

  1. Basic Modal support 

    This adds Modals without animation, presentation style,
or orientation management.
    @imnotjames
    imnotjames committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    6ab1f0f View commit details
    Browse the repository at this point in the history

  2. add janky storybook for modals

    @imnotjames
    imnotjames committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    d480a39 View commit details
    Browse the repository at this point in the history

  3. add accessibility role and aria-modal flag 

    this replaces setting aria-hidden on everything else
per https://www.w3.org/TR/wai-aria-practices/examples/dialog-modal/dialog.html
    @imnotjames
    imnotjames committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    e9a2ae0 View commit details
    Browse the repository at this point in the history

  4. clean up helpers that wrap prop callbacks

    @imnotjames
    imnotjames committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    472ce71 View commit details
    Browse the repository at this point in the history

  5. add listener for escape to call onRequestClose

    @imnotjames
    imnotjames committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    13807b3 View commit details
    Browse the repository at this point in the history

  6. support onRequestClose in storybook

    @imnotjames
    imnotjames committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    b21903d View commit details
    Browse the repository at this point in the history

  7. trap focus in the modal

    @imnotjames
    imnotjames committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    8218161 View commit details
    Browse the repository at this point in the history

  8. add example for modal in a modal

    @imnotjames
    imnotjames committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    e264f2d View commit details
    Browse the repository at this point in the history

  9. support multiple modals at once

    @imnotjames
    imnotjames committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    900fb2e View commit details
    Browse the repository at this point in the history

  10. refactor modal to support modal animations

    @imnotjames
    imnotjames committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    44d1c91 View commit details
    Browse the repository at this point in the history

  11. add some comments to the modal + canUseDOM

    @imnotjames
    imnotjames committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    6b10b8d View commit details
    Browse the repository at this point in the history

  12. linting of the modal

    @imnotjames
    imnotjames committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    a11b679 View commit details
    Browse the repository at this point in the history

  13. storybook improvements & linting

    @imnotjames
    imnotjames committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    b04fdfa View commit details
    Browse the repository at this point in the history

  14. types & linting

    @imnotjames
    imnotjames committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    397c551 View commit details
    Browse the repository at this point in the history

  15. add examples to props to help explain what they do

    @imnotjames
    imnotjames committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    6b2fc42 View commit details
    Browse the repository at this point in the history

  16. clean up comments to add project license

    @imnotjames
    imnotjames committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    79c0543 View commit details
    Browse the repository at this point in the history

  17. remove spurious $

    @imnotjames
    imnotjames committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    7df4442 View commit details
    Browse the repository at this point in the history

  18. rewrite to use functional react components

    @imnotjames
    imnotjames committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    04ea623 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2020

  1. add flow types

    @imnotjames
    imnotjames committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    c8d7674 View commit details
    Browse the repository at this point in the history

  2. use styles & css animations instead of Animated

    @imnotjames
    imnotjames committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    b724ff8 View commit details
    Browse the repository at this point in the history

  3. call the animationEndCallback when not animated

    @imnotjames
    imnotjames committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    8f6e5f3 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2020

  1. IE11 doesn't support .includes

    @imnotjames
    imnotjames committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    d49bee3 View commit details
    Browse the repository at this point in the history

  2. stop wrapping callbacks per PR request

    @imnotjames
    imnotjames committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    7551680 View commit details
    Browse the repository at this point in the history

  3. simplify focusBracket implementation

    @imnotjames
    imnotjames committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    b714ce5 View commit details
    Browse the repository at this point in the history

  4. fix style issues with return value & semicolons

    @imnotjames
    imnotjames committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    23b9ae5 View commit details
    Browse the repository at this point in the history

  5. combine if-blocks for style purposes

    @imnotjames
    imnotjames committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    93502a8 View commit details
    Browse the repository at this point in the history

  6. add a bit of wiggle to modalception example 

    this makes it clearer that the example has multiple open modals at once
    @imnotjames
    imnotjames committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    4f6be74 View commit details
    Browse the repository at this point in the history

  7. move the focus trapping to its own module

    @imnotjames
    imnotjames committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    6bf04a0 View commit details
    Browse the repository at this point in the history

  8. clean up flow types for modals 

    move internal flow types into their respective internal modules
create a flow type for ModalFocusTrap
    @imnotjames
    imnotjames committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    3454f37 View commit details
    Browse the repository at this point in the history

  9. create style arrays at root of modal module

    @imnotjames
    imnotjames committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    2bbedc2 View commit details
    Browse the repository at this point in the history

  10. drop visibility style property

    @imnotjames
    imnotjames committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    e366a4c View commit details
    Browse the repository at this point in the history

  11. drop deprecated animated prop 

    this was dropped in 0.63 and now react-native-web doesn't support
anything lower than 0.63
    @imnotjames
    imnotjames committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    ae868d7 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2020

  1. use long-form outline

    @imnotjames
    imnotjames committed Aug 15, 2020
    Configuration menu
    Copy the full SHA
    ef9c1c8 View commit details
    Browse the repository at this point in the history

  2. set focus trap to active by default

    @imnotjames
    imnotjames committed Aug 15, 2020
    Configuration menu
    Copy the full SHA
    604d0a8 View commit details
    Browse the repository at this point in the history

  3. handle modals without focusable elements

    @imnotjames
    imnotjames committed Aug 15, 2020
    Configuration menu
    Copy the full SHA
    7491592 View commit details
    Browse the repository at this point in the history

  4. share isActiveModal function

    @imnotjames
    imnotjames committed Aug 15, 2020
    Configuration menu
    Copy the full SHA
    56db03e View commit details
    Browse the repository at this point in the history

  5. prevent calling the active function if not needed

    @imnotjames
    imnotjames committed Aug 15, 2020
    Configuration menu
    Copy the full SHA
    5a81651 View commit details
    Browse the repository at this point in the history

  6. trap focus on initial render as well as when focus occurs

    @imnotjames
    imnotjames committed Aug 15, 2020
    Configuration menu
    Copy the full SHA
    2b22dda View commit details
    Browse the repository at this point in the history

  7. stop passing styles into ModalAnimation

    @imnotjames
    imnotjames committed Aug 15, 2020
    Configuration menu
    Copy the full SHA
    8c06fa6 View commit details
    Browse the repository at this point in the history

  8. remove modal from "active" stack when unmounting

    @imnotjames
    imnotjames committed Aug 15, 2020
    Configuration menu
    Copy the full SHA
    819382e View commit details
    Browse the repository at this point in the history

  9. add tests for ModalAnimation / ModalFocusTrap / ModalPortal

    @imnotjames
    imnotjames committed Aug 15, 2020
    Configuration menu
    Copy the full SHA
    328d307 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2020

  1. don't need computedAnimation without the deprecated animated prop

    @imnotjames
    imnotjames committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    605d72c View commit details
    Browse the repository at this point in the history

  2. move container display logic to another module

    @imnotjames
    imnotjames committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    123bb43 View commit details
    Browse the repository at this point in the history

  3. use a listener instead of passing functions around for active 

    this allows us to set the "active" status of each modal as other
modals are being placed over top of them to keep track
    @imnotjames
    imnotjames committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    346fdd8 View commit details
    Browse the repository at this point in the history

  4. move around props per linter

    @imnotjames
    imnotjames committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    a38e76c View commit details
    Browse the repository at this point in the history

  5. only set the dialog role if active

    @imnotjames
    imnotjames committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    d75ca25 View commit details
    Browse the repository at this point in the history

  6. add test for modal

    @imnotjames
    imnotjames committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    274da42 View commit details
    Browse the repository at this point in the history

  7. set flags so aria-hidden gets included

    @imnotjames
    imnotjames committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    954d0d6 View commit details
    Browse the repository at this point in the history

  8. check for roles & aria-hidden in tests

    @imnotjames
    imnotjames committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    e5f23a8 View commit details
    Browse the repository at this point in the history

  9. test for dialog being set via ModalContent

    @imnotjames
    imnotjames committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    7a42b56 View commit details
    Browse the repository at this point in the history

  10. remove spurious brackets in ModalFocusTrap

    @imnotjames
    imnotjames committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    2d7f83f View commit details
    Browse the repository at this point in the history

  11. active flag is not set by default

    @imnotjames
    imnotjames committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    c546dc3 View commit details
    Browse the repository at this point in the history

  12. update snapshot

    @imnotjames
    imnotjames committed Aug 16, 2020
    Configuration menu
    Copy the full SHA
    a15826f View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2020

  1. combine tests into a test file against Modal

    @imnotjames
    imnotjames committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    0987b1e View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2020

  1. fix linting error

    @imnotjames
    imnotjames committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    769f919 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2020

  1. check in the ModalFocusTrap & ModalPortal that we canUseDOM

    @imnotjames
    imnotjames committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    7457653 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2020

  1. always keep the contents of the modal mounted

    @imnotjames
    imnotjames committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    8dcc5e3 View commit details
    Browse the repository at this point in the history

  2. drop unsupported props from the docs

    @imnotjames
    imnotjames committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    ee377bb View commit details
    Browse the repository at this point in the history

  3. combine if blocks

    @imnotjames
    imnotjames committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    e63c617 View commit details
    Browse the repository at this point in the history

  4. simplify ModalContent canUseDom check

    @imnotjames
    imnotjames committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    cdb9f85 View commit details
    Browse the repository at this point in the history

  5. clean up Modal docs

    @imnotjames
    imnotjames committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    40549e1 View commit details
    Browse the repository at this point in the history

  6. move types into the entry file

    @imnotjames
    imnotjames committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    5dd2bc5 View commit details
    Browse the repository at this point in the history

  7. remove extra spaces for style reasons

    @imnotjames
    imnotjames committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    a0bbafe View commit details
    Browse the repository at this point in the history

  8. fix example exports

    @imnotjames
    imnotjames committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    c5ebf2d View commit details
    Browse the repository at this point in the history

  9. move effect into canUseDOM

    @imnotjames
    imnotjames committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    dfc4783 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2020

  1. bring back isRendering flag on ModalAnimation with hidden style 

    instead of completely unmounting when not rendering, instead
just set `display: none` on the modal
    @imnotjames
    imnotjames committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    d515c5d View commit details
    Browse the repository at this point in the history

  2. only call unanimated anim end callback when visible changes

    @imnotjames
    imnotjames committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    cb54c6c View commit details
    Browse the repository at this point in the history

  3. refactor ModalPortal per next.js docs

    @imnotjames
    imnotjames committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    e311e3b View commit details
    Browse the repository at this point in the history

  4. fix so test against initial hidden fires onDismissed callback

    @imnotjames
    imnotjames committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    09e49ef View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. Modal visible by default

    @imnotjames
    imnotjames committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    5b3251a View commit details
    Browse the repository at this point in the history

  2. unmount modal children when !visible & !rendering 

    this is to improve integration support with react-native-modal
while still umounting contents when we've been hidden
    @imnotjames
    imnotjames committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    e2146e8 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. add tests for focus wrapping & fix focus wrapping backwards

    @imnotjames
    imnotjames committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    af6d7b0 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. alphabetize the documentation

    @imnotjames
    imnotjames committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    283f686 View commit details
    Browse the repository at this point in the history

  2. updates per review

    @imnotjames
    imnotjames committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    0d4445e View commit details
    Browse the repository at this point in the history

  3. prevent onDismiss callback from firing when initially hidden

    @imnotjames
    imnotjames committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    2685972 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2020

  1. when empty, the trap target should receive focus

    @imnotjames
    imnotjames committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    a51ace3 View commit details
    Browse the repository at this point in the history