Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mount text tree performance tests broken #2210

Closed
s0rthak opened this issue Jan 30, 2022 · 0 comments
Closed

Mount text tree performance tests broken #2210

s0rthak opened this issue Jan 30, 2022 · 0 comments
Labels
has: pr Subject of a pull request
Milestone
0.18: StyleSheet

Comments

@s0rthak
Copy link

s0rthak commented Jan 30, 2022

The problem

Benchmark "Mount text tree" on this page: https://necolas.github.io/react-native-web/benchmarks/ is broken for some libraries

How to reproduce

Simplified test case: N/A

Steps to reproduce:

  1. Go to https://necolas.github.io/react-native-web/benchmarks/
  2. Select "Mount text tree" in benchmark.
  3. Then select styled-components in library (also see for other libraries except react-native-web)
  4. React App crashes
  5. In console, the following error is shown:
Error: Minified React error #130; visit https://reactjs.org/docs/error-decoder.html?invariant=130&args[]=undefined&args[]=

Expected behavior

The performance tests application should not crash

Environment (include versions). Did this work in previous versions?

  • React Native for Web (version): N/A
  • React (version): N/A
  • Browser: Firefox 96
@necolas necolas mentioned this issue Jan 31, 2022
Closed
7 tasks
@necolas necolas added this to the 0.18: StyleSheet milestone Mar 1, 2022
necolas added a commit that referenced this issue Mar 2, 2022
@necolas
Update packages and benchmarks
a12c621 
Remove libraries from benchmarks as comparison to css-modules baseline is what
matters. This makes benchmark builds faster and will reduce how often people
open PRs asking for their library to be included.

Close #2210
@necolas necolas added the has: pr Subject of a pull request label Mar 2, 2022
necolas added a commit that referenced this issue Mar 2, 2022
@necolas
Update packages and benchmarks
314d78c 
Remove libraries from benchmarks as comparison to css-modules baseline is what
matters. This makes benchmark builds faster and will reduce how often people
open PRs asking for their library to be included.

Close #2210
rnike pushed a commit to VeryBuy/react-native-web that referenced this issue Sep 13, 2022
@necolas
Update packages and benchmarks
f597615 
Remove libraries from benchmarks as comparison to css-modules baseline is what
matters. This makes benchmark builds faster and will reduce how often people
open PRs asking for their library to be included.

Close necolas#2210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has: pr Subject of a pull request
Projects
None yet
Milestone
0.18: StyleSheet
Development

Successfully merging a pull request may close this issue.

StyleSheet with styleq runtime necolas/react-native-web
2 participants
@necolas @s0rthak