Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled element color inheritance #502

Merged
merged 2 commits into from
Jan 23, 2016
Merged

Disabled element color inheritance #502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5ffb63
Remove color inheritance for button, input, optgroup, select and text…
Jan 22, 2016
faf5abc
Remove unnecessary color inheritance test now that it has been remove…
Jan 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions normalize.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,20 +252,17 @@ samp {
*/

/**
* 1. Correct color not being inherited.
* Known issue: affects color of disabled elements.
* 2. Correct font properties not being inherited.
* 3. Address margins set differently in Firefox 4+, Safari, and Chrome.
* 1. Correct font properties not being inherited.
* 2. Address margins set differently in Firefox 4+, Safari, and Chrome.
*/

button,
input,
optgroup,
select,
textarea {
color: inherit; /* 1 */
font: inherit; /* 2 */
margin: 0; /* 3 */
font: inherit; /* 1 */
margin: 0; /* 2 */
}

/**
Expand Down
12 changes: 0 additions & 12 deletions test.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,18 +258,6 @@ <h3 class="Test-it">should render <code>em</code>-unit preformatted text at the
</div>

<h2 class="Test-describe"><code>button</code>, <code>input</code>, <code>optgroup</code>, <code>select</code>, <code>textarea</code></h2>
<h3 class="Test-it">should inherit <code>color</code> from ancestor</h3>
<div class="Test-run" style="color:#ADD8E6;">
<button>button</button><br>
<input value="input"><br>
<select style="border:1px solid #999;">
<optgroup label="optgroup">
<option>option</option>
</optgroup>
<option>option</option>
</select><br>
<textarea>textarea</textarea>
</div>
<h3 class="Test-it">should inherit <code>font</code> from ancestor</h3>
<div class="Test-run" style="font:bold italic 20px/1 serif;">
<button>button</button><br>
Expand Down