-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add missing conversions #22
Conversation
Well, thanks, I'd hope that this PR gets merged but probably not any time soon (ref @nebrelbug's status). @slorber and I have probably settled on forking this library as his own so we can do some overhaul in it |
generally i would like to drop rolup form it, and make it module, add actual args parsing, and rebuild them, but for now i followed code style and i just added simple regexps, there is actually lots of edge cases that are not supported.... |
Yep, I tried forking & making some updates in the Docusaurus repo, but I was later informed that FB isn't particularly willing to maintain external deps and would rather keep them external. The implementation of this package differs significantly from my imagination🤦♂️ |
@armano2 Your fork didn't have issues enabled so I'll just post the note here. I just spotted that |
unfortunately npm2yarn does not remove it yet :( requires nebrelbug/npm-to-yarn#22
Since I just returned from my mission, I've finally had a chance to review this PR. It looks good, so I'll merge right now and publish a new release as version 1.2.0. Thanks so much for the good work! I'll leave issue #8 open, since it appears not to be completely resolved (converting the examples given in the issue summary doesn't return the desired results). |
@Josh-Cena @armano2 like you mentioned, this package is a bit hacky and would need a significant overhaul to be super reliable. The CI and build process should be updated as well. I'm fairly busy right now, so I don't think I'm going to have time in the next few months to work on this package intensively. I would like to modernize the build process, but I may not have time for that either in the next few months. I'm happy to review issues and merge PRs, and will try to work on the package when I have time. I already added @slorber as a contributor, and am happy to add either of you if you'd like -- and/or to explore options for transferring ownership. |
I actually progressed quiet far with fixing issues, I will submit additional pr |
@armano2 have you made any progress on the additional PR? |
@nebrelbug i forgot to push/commit my changes, PR submitted #36 |
add missing conversion for:
yarn create name
->npm init name
andyarn init name
->npm create name
npm run x -- --args
->yarn x --args
oryarn run x --args
npm ls abc bcd
->yarn list --pattern "abc|bcd"
fixes #21, fixes #8, fixes #7
cc: @slorber @Josh-Cena
ref: facebook/docusaurus#5635 facebook/docusaurus#5861 issue