Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

replace nullable sql field params #566

Merged
merged 1 commit into from
Jun 6, 2019
Merged

replace nullable sql field params #566

merged 1 commit into from
Jun 6, 2019

Conversation

ovhemert
Copy link
Contributor

@ovhemert ovhemert commented Jun 5, 2019

Replace undefined params with null before constructing the SQL object.
This prevents throwing an error from inside @nearform/sql >= v1.3.1.

Fixes issue #565

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.153% when pulling c6f8de9 on ovhemert:fix-sql-undefined-params into 1e69f8e on nearform:master.

mcollina
mcollina approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you land and issue a release?

@dberesford dberesford merged commit 62fe32e into nearform:master Jun 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ovhemert @coveralls @mcollina @dberesford