This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
allow underscores on id fields for backward compatibility #549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
underscores now whitelisted in all fields to cater for backward compatibility for teams in particular (as underscores were previously enforced).
Migration script updated with regex to cater for underscore and also validation.js in core updated too for all ids
As team paths only allow underscores and alphanumerics (ltree restriction), we must convert hyphens in ids to underscores in the path. this may cause clashes and undesired behaviour so an extra constraint was added to ensure path is unique in migration script.
a test case was added to ensure the database cannot contain two teams with the same path when ids with hypens and underscores convert to to the same path.
paths will be returned with hypens from a user perspective (for easier use of API when we eventually expose calls that use the path), as our default id separator is hyphen (a bug relating to this was fixed in nested teams)
Updated some formatting in overview, and fixed problems in example.md