This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
Fix multi variable policies #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floridemai
reviewed
Dec 23, 2017
| }, { | ||
| key: 'sharedPolicy' | ||
| }] | ||
| policies: [ |
There was a problem hiding this comment.
Would you do me the favour of "duplicating" policyWithVariables rather than policyWithVariablesMulti (btw to me this name kind of suggested some kind of feature... which is not the case 😕 )
For someone reading the tests for policies with variables for the first time, I must say that the names and values chosen lean more towards confusion and not clarity. But no need to take action If you don't feel like 😄
|
Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of policies with variables you could assign the same policy to the same user but having different variables. The checkPoliciesOrg was failing because in this case where you have duplicate policy IDs the query returns less results that the policy array as the query does not return duplicate entries.
Added also a fix on the
decoreateUdaruCoreretrieval,configwas of type Reconfig and confg properties are accessed using.get(property)