Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

Fixes #438

Merged
merged 2 commits into from
Nov 15, 2017
Merged

Fixes #438

merged 2 commits into from
Nov 15, 2017

Conversation

mihaidma
Copy link
Contributor

  • Hit a migration issue with the create extension command. It it crashing when applied on two tenants/schemas on the same database. This change adds a bad breaking change, solutions using 2.0 migrations will not be able to use migrations to move to 3.0.

  • Moved the Factory functionality into the scripts because it is really handy for generating policies and could be enhanced further to be exposed to clients. Having it in the tests folder might not be the best place if you want to use it from outside. Factory could be a great tool for implementing import and export or generating test data from JSON.

@coveralls
Copy link

coveralls commented Nov 10, 2017

Coverage Status

Coverage decreased (-0.1%) to 96.261% when pulling 7edcf2e on fixes into 16d9126 on master.

Copy link
Contributor

@floridemai floridemai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mihaidma
Copy link
Contributor Author

Thank you @floridemai

@mihaidma mihaidma merged commit a7758fa into master Nov 15, 2017
@mihaidma mihaidma deleted the fixes branch November 15, 2017 07:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants