Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

Add statemets as an object instead of a string in policy creation/update #306

Merged
merged 2 commits into from
Jan 23, 2017

Conversation

p16
Copy link
Contributor

@p16 p16 commented Jan 20, 2017

This PR changes the policy statemets property from a string to an object when creating or updating a policy.

Ref. issue #284

Copy link
Member

@paolochiodi paolochiodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also modify all tests the send statements as strings (i.e. authorization, integration...)

I was also thinking, would be more clear it the expected object was something like

         statements: [
              {
                Effect: 'Deny',
                Action: ['documents:Read'],
                Resource: ['wonka:documents:/public/*']
              }
            ]

without the need of "Statement"?

I understand it would be more work for us for the mapping, but I'd thing it would make everything more clear

@p16
Copy link
Contributor Author

p16 commented Jan 20, 2017

@paolochiodi

modify all tests the send statements

will do, did not remember them :)

without the need of "Statement"

there's a ticket for that :) #197

@p16 p16 force-pushed the issue-284-statements-param-as-object branch from da9b70c to 115d3d0 Compare January 20, 2017 16:49
@p16 p16 merged commit d495050 into master Jan 23, 2017
@mcdonnelldean mcdonnelldean deleted the issue-284-statements-param-as-object branch January 24, 2017 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants