Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SQL.js #210

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Imran-imtiaz48
Copy link

Improvements:
• Used modern JavaScript syntax (?., .at(-1), spread operator). • Enhanced readability by simplifying expressions. • Improved consistency in formatting and string operations. • Optimized array operations with .reduce() and .map() where applicable.

Improvements:
•	Used modern JavaScript syntax (?., .at(-1), spread operator).
•	Enhanced readability by simplifying expressions.
•	Improved consistency in formatting and string operations.
•	Optimized array operations with .reduce() and .map() where applicable.
Copy link

github-actions bot commented Mar 5, 2025

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is introducing many formatting changes that are unrelated to the modifications you are trying to do. Please undo the formatting changes and only include the actual changes to the language syntax.

@ilteoood
Copy link
Contributor

ilteoood commented Mar 6, 2025

I would also avoid removing the for loops in favour of the map + reduce combination.
As you can see here, the plain for loop is always faster.
Taking into account that this is a core library for us, I would avoid slowing it down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants