Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/297 custom icons #299

Merged
merged 6 commits into from
Jan 15, 2024
Merged

Fix/297 custom icons #299

merged 6 commits into from
Jan 15, 2024

Conversation

andreaforni
Copy link
Contributor

@andreaforni andreaforni commented Jan 12, 2024

Closes #297

This PR replaces the hardcoded icons with the Bootstrap Icon library thanks to the react-icons package. The latter provides React icon components of many famous icon libraries.

The PR:

  • Removes all the custom icons in src/assets/build/ except for the open-source.icon that is not provided by Bootstrap.
  • Imports all the Bootstrap icons in the src/assets/index.ts file, so all the components can import icons from @/assets as before.
  • Replaces the old icons with the new ones.
  • Removes the "Icons" page in Storybook. Quantum does not provide its icon set, so there is no point in displaying that page.

@andreaforni andreaforni marked this pull request as ready for review January 15, 2024 10:06
Copy link

@review-bot-for-github review-bot-for-github bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! No comments.

Copy link
Contributor

@marceloFerreira90 marceloFerreira90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you add a line to the Readme about where the look them up?

@andreaforni andreaforni reopened this Jan 15, 2024
@andreaforni andreaforni merged commit 4b69ca9 into main Jan 15, 2024
8 checks passed
@andreaforni andreaforni deleted the fix/297-custom-icons branch January 15, 2024 10:59
@github-actions github-actions bot mentioned this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace custom icons with a third-party library
2 participants